Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new TV icon in iOS 14 #684

Open
wants to merge 162 commits into
base: master
Choose a base branch
from
Open

Conversation

anhtuanng98
Copy link

In iOS14, TV accessory appear Home icon. Please check that and update addon.
Thank you and best regards.

kiwi-cam and others added 30 commits October 1, 2019 13:36
* Fixed unused mode hexcodes

The heat/cool/auto hex codes in the configuration were unused ?!?!? This is to use these to set the mode, and the temp hex to set temperature for units that have seperate codes. 
mode hex codes are optional in the config. Temperature codes will be sent instead assuming these contain the mode information for the AC unit.

* Mode change clean-up

Separated mode change code from sendTemperature to setTargetHeatingCoolingState to allow it to run when only the mode changes.
* Turn the unit on first if required, and defined
iOS13/tvOS13 appears to poll the device status more frequently. Adjusted default temperature update times to reduce duplication
* Updated README.md to include notes on new features
* Fixed unused mode hexcodes

The heat/cool/auto hex codes in the configuration were unused ?!?!? This is to use these to set the mode, and the temp hex to set temperature for units that have seperate codes. 
mode hex codes are optional in the config. Temperature codes will be sent instead assuming these contain the mode information for the AC unit.

* Mode change clean-up

Separated mode change code from sendTemperature to setTargetHeatingCoolingState to allow it to run when only the mode changes.

* Temperature Refresh optimisations

iOS13/tvOS13 appears to poll the device status more frequently. Adjusted default temperature update times to reduce duplication.
Removed duplicate onTemperature Calls to speed up refresh
ignoreTemperatureWhenOff only applied when off and staying off. This means that when transitioning to off mode, a temperature hexcode was attempted. Now ignores if the target is off, regardless of the current mode.
Removed set temperature from all state updates. Cleaned up targetTemperature refresh to only be on temperature changes.
UI slow on "Updating", changed temperature update frequency of W1 and file updates to 5 minutes instead of 10.
Coded with a minimum of 60 seconds to avoid high unnecessary disk IO - with default value of 10 for this parameter.
w1 devices read straight from the bus, no IO impact so no need to limit refresh interval
* Improved ping error handling

Removed exception throw and treated as a non response to allow retries

Fixes #45
* Re-enabled additional device temp check
* Fixed device state logic post changes
* Improved status handling
* Bug fix when falling back to 'classic mode'
Was failing to load temperatureX hexcodes from config. Fixes #60
* Support various new RM Mini devices by updating to the latest broadlinkjs-rm library
* Support for resetting to a default fan speed each time a fan is turned on
          "alwaysResetToDefaults": true,
          "defaultFanSpeed": 30,
* Support for a “window” accessory that mimic the functionality of a window-covering
* Added support for Air Purifier accessories
* Added default state for lock controls
* Added support for Humidifier/Dehumidifiers 
* Garage Door Opener - If the `autoCloseDelay` is set to `0`, set the Homekit state to closed immediately
* Allow for separate commands for turning swing mode/oscillation on/off 
* Fixed a potential crash when learning RF data
* Updated packages to resolve potential security issues.
* Improvements to how ping’s work to improve performance and device re-discovery
Temperature would be set to default mode temperature, regardless of request
Also fixed UI refresh when turning off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants